Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: fix type of MinResources in podgroup #2212

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

zwzhang0107
Copy link
Contributor

Ⅰ. Describe what this PR does

the type of MinResources is v1.ResourceList in upstream
https://github.com/kubernetes-sigs/scheduler-plugins/blob/release-1.28/apis/scheduling/v1alpha1/types.go#L145

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.68%. Comparing base (749b14d) to head (ccef094).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
- Coverage   67.72%   67.68%   -0.05%     
==========================================
  Files         446      446              
  Lines       42686    42719      +33     
==========================================
+ Hits        28908    28913       +5     
- Misses      11259    11280      +21     
- Partials     2519     2526       +7     
Flag Coverage Δ
unittests 67.68% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot merged commit 0fbf87e into koordinator-sh:main Sep 24, 2024
21 checks passed
@zwzhang0107 zwzhang0107 deleted the fix-podgroup-api branch September 24, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants