apis: add reservation name, taints and tolerations in ReservationAffinitty #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
==========================================
- Coverage 67.72% 67.71% -0.02%
==========================================
Files 446 446
Lines 42686 42686
==========================================
- Hits 28908 28903 -5
- Misses 11259 11264 +5
Partials 2519 2519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zwzhang0107
force-pushed
the
reserve-taint-tolerance
branch
from
62efa24 to
eba7f7c
Compare
zwzhang0107
changed the title
|
/lgtm |
jasonliu747
approved these changes
Sep 2, 2024
hormes
reviewed
Sep 2, 2024
…nitty Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
zwzhang0107
force-pushed
the
reserve-taint-tolerance
branch
from
eba7f7c to
d424c20
Compare
|
New changes are detected. LGTM label has been removed. |
hormes
approved these changes
Sep 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
add taint and tolerance for reservation
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test