-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: support resource amplification config, cpu, memory and other resource #2172
Conversation
PTAL, thanks. @saintube @jasonliu747 @FillZpp |
50f9efd
to
df47eb7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2172 +/- ##
==========================================
- Coverage 67.88% 67.88% -0.01%
==========================================
Files 443 444 +1
Lines 41921 42089 +168
==========================================
+ Hits 28460 28574 +114
- Misses 11006 11055 +49
- Partials 2455 2460 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
df47eb7
to
671cf7e
Compare
pkg/slo-controller/noderesource/plugins/resourceamplification/configmap_event_handler.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/resourceamplification/configmap_event_handler.go
Outdated
Show resolved
Hide resolved
533f959
to
c1b2e57
Compare
pkg/slo-controller/noderesource/plugins/resourceamplification/configmap_event_handler_test.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/resourceamplification/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/resourceamplification/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/resourceamplification/plugin.go
Outdated
Show resolved
Hide resolved
c1b2e57
to
c95f252
Compare
pkg/slo-controller/noderesource/plugins/resourceamplification/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/resourceamplification/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/resourceamplification/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/resourceamplification/plugin.go
Outdated
Show resolved
Hide resolved
pkg/slo-controller/noderesource/plugins/resourceamplification/plugin.go
Outdated
Show resolved
Hide resolved
c95f252
to
dad0172
Compare
… other resource Signed-off-by: yangfeiyu20102011 <yangfeiyu20102011@163.com>
dad0172
to
4d81aa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, saintube, zqzten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Support resource amplification config, cpu and memory.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test