koord-manager: fix invalid assignments in the resource amplification …

[yangfeiyu20102011]

Ⅰ. Describe what this PR does

NodeResourceAmplificationPlugin func handleUpdate

In the else branch, the assignment to originalResources does not take effect in the subsequent process, which might be a typographical error.
It will print "admit for node-x, skip resource cpu as it is not found in original resources",
and resource will not be amplified.
This result is unexpected.

This PR fixes the issue and adds some useful information.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in make test

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (7eaa33a) to head (f43a9b6).

Files	Patch %	Lines
...ns/resourceamplification/resource_amplification.go	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2149   +/-   ##
=======================================
  Coverage   67.89%   67.89%           
=======================================
  Files         443      443           
  Lines       41920    41921    +1     
=======================================
+ Hits        28463    28464    +1     
+ Misses      11006    11004    -2     
- Partials     2451     2453    +2     

Flag	Coverage Δ
unittests	67.89% <50.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[saintube]

PTAL /cc @zqzten

[zqzten]

Yeah that's a bug I think. /cc @hormes can make a double check on that.

Also, this case is not covered in test now, it would be nice if you can also add a test for it to ensure the fix.

[zqzten]

/lgtm

[koordinator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/webhook/OWNERS [hormes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment