-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: add reservation preemption #2139
scheduler: add reservation preemption #2139
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
==========================================
- Coverage 67.90% 67.77% -0.13%
==========================================
Files 443 444 +1
Lines 41967 42186 +219
==========================================
+ Hits 28496 28590 +94
- Misses 11016 11113 +97
- Partials 2455 2483 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1d3465e
to
e7e8302
Compare
3ec6fc9
to
21c293d
Compare
39d0f22
to
b1d2a25
Compare
@ZiMengSheng @hormes The implementation of the reservation ignored can be a large patch. So it is split to another PR. |
ad1a640
to
ee3bb6e
Compare
8f5f912
to
c601a62
Compare
/lgtm |
please give a points list of why we don't use upstream DefaultPreemption in PR Description |
Added. |
Signed-off-by: saintube <saintube@foxmail.com>
cb539ab
to
9450e1a
Compare
…th deletion Signed-off-by: saintube <saintube@foxmail.com>
9450e1a
to
b5e93b4
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, ZiMengSheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test