Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: support consume reserved numa resource #2080

Merged

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Jun 5, 2024

Ⅰ. Describe what this PR does

support pod cunsume reserved numa resource

implements #228 - koord-scheduler supports Pod allocate from Reservation according NUMA Topology

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from buptcozy and eahydra June 5, 2024 07:21
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 71.11801% with 93 lines in your changes missing coverage. Please review.

Project coverage is 68.57%. Comparing base (8e41abc) to head (86446cf).
Report is 10 commits behind head on main.

Files Patch % Lines
.../scheduler/plugins/nodenumaresource/reservation.go 69.79% 38 Missing and 7 partials ⚠️
pkg/scheduler/plugins/nodenumaresource/plugin.go 69.41% 19 Missing and 7 partials ⚠️
...duler/plugins/nodenumaresource/resource_manager.go 83.67% 5 Missing and 3 partials ⚠️
...cheduler/plugins/nodenumaresource/topology_hint.go 66.66% 3 Missing and 3 partials ⚠️
...eduler/plugins/nodenumaresource/node_allocation.go 50.00% 2 Missing and 2 partials ⚠️
pkg/scheduler/plugins/nodenumaresource/scoring.go 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2080      +/-   ##
==========================================
- Coverage   68.62%   68.57%   -0.06%     
==========================================
  Files         430      430              
  Lines       39540    39829     +289     
==========================================
+ Hits        27136    27311     +175     
- Misses      10061    10162     +101     
- Partials     2343     2356      +13     
Flag Coverage Δ
unittests 68.57% <71.11%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@ZiMengSheng ZiMengSheng force-pushed the consume_reserved_numaResource branch from 92d57a5 to 86446cf Compare June 6, 2024 06:20
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@ZiMengSheng
Copy link
Contributor Author

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZiMengSheng, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ba299ed into koordinator-sh:main Jun 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants