-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chores(deps): Add support depguard rules in golangci-lint #1965
chores(deps): Add support depguard rules in golangci-lint #1965
Conversation
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
==========================================
+ Coverage 68.56% 68.58% +0.02%
==========================================
Files 430 430
Lines 39857 39857
==========================================
+ Hits 27328 27336 +8
+ Misses 10172 10163 -9
- Partials 2357 2358 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@eahydra PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @hormes |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jasonliu747 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Go 1.16 deprecated several io/ioutil functions.
ref: https://pkg.go.dev/io/ioutil
Add support depguard rules in golangci-lint
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test