Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores(deps): Add support depguard rules in golangci-lint #1965

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

dongjiang1989
Copy link
Contributor

Ⅰ. Describe what this PR does

Go 1.16 deprecated several io/ioutil functions.

ioutil.ReadFile -> os.ReadFile
ioutil.ReadAll -> io.ReadAll
ioutil.ReadDir -> os.ReadDir

ref: https://pkg.go.dev/io/ioutil

Add support depguard rules in golangci-lint

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.58%. Comparing base (ba299ed) to head (e4d1d71).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1965      +/-   ##
==========================================
+ Coverage   68.56%   68.58%   +0.02%     
==========================================
  Files         430      430              
  Lines       39857    39857              
==========================================
+ Hits        27328    27336       +8     
+ Misses      10172    10163       -9     
- Partials     2357     2358       +1     
Flag Coverage Δ
unittests 68.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongjiang1989
Copy link
Contributor Author

@eahydra PTAL

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dongjiang1989
Copy link
Contributor Author

/assign @hormes

@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@koordinator-bot koordinator-bot bot removed the lgtm label Mar 25, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jasonliu747
To complete the pull request process, please ask for approval from hormes after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit aacf585 into koordinator-sh:main Sep 6, 2024
22 checks passed
@dongjiang1989 dongjiang1989 deleted the ioutil-clean branch September 20, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants