merge updates from upstream #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clude paths for dependencies (#118)
* add parser support for oneof and map fields. I'm mostly interested in the parser and not in the C extensions generated so I've improved the parser while keeping its default behaviour intact. I'm not a C guy so nothing I can help with adding the complete support for the new fields. I do hope it might help folks down the line add the full support. Commit includes: * add support for oneof field in parser. * add support for map fields in parser. * add capability to disable specific tokens in parser. * disable the new oneof and map field by default in the parser to make sure the parser works with the C extensions out-of-the-box. * add informative exceptions for disabled parser tokens. * simplify the `tokenize` code by creating parsable tokens mapping from name to class. * change a few function-level variable names to improve clarity * add a few docstrings * add testing instructions to the README * shorten parser class member * add unittests for the map field and oneof tokens all parser related unittests grouped under the `test_parser` folder. * update .gitignore with .pytest_cache * add flake8 config to `tox.ini` and fix all issues in `parse_proto.py`
* add conftest to build messages and set path prior to collection/running tests * clean up tests * update README for testing changes * edits * some fixes and version bump * only write generated cython code if it differs from what's there (to avoid unnecessary compilation) * add clean argument to compiler to force recompilation of messages
* Prevent name and index collisions in fields and enums * Add test cases for collisions and invalid field indices * Check collisions between enum fields and names in current scope * Add message names to scope checking * Update templates with changes * Add test cases for more name collisions * Fix error * Fix broken tests * Resolve scope name in _parse_enum * bump version
* first steps toward improving custom option handling in parser * fixed bug in enum default parsing; all tests passing * cleanup * bug fix and cleanup - now able to parse some pretty tricky AppNexus messages * up version * add quick test for custom options
* use bitmaps to track which fields are set instead of bint fields * fix perf test * add test for HasField on message with many fields * up version
…kage parameter and always defaulting to pyrobuf_generated
Fix broken setuptools_ext
This involves modifying unit tests to run similar/identical tests on proto3 variants where needed, and omitting tests that test proto2-specific behavior.
The parser does not support oneof in proto2 syntax, although that could be remedied. These oneofs conform to the behavior of oneofs in the upstream implementation, and simply use the fields that are in the parent message, clearing sibling fields where needed.
Fixed generated egg name not respecting package name parameter
…opisMobile-oneof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.