🐛 Sort Questionnaire items on fetch #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A questionnaire's sections, questions and answers all have a order key. The key needs to be present in the defining yaml file, but does not need to be in sorted order. To ensure that the UI always has questionnaire items in proper order order, sort everything in the fetch hooks. Note: Hub returns the questionnaire in the same order as the original yaml file. We need to make sure things are sorted properly. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
==========================================
- Coverage 39.36% 39.27% -0.09%
==========================================
Files 146 146
Lines 4816 4827 +11
Branches 1152 1152
==========================================
Hits 1896 1896
- Misses 2906 2917 +11
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Dec 11, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A questionnaire's sections, questions and answers all have a order key. The key needs to be present in the defining yaml file, but does not need to be in sorted order. To ensure that the UI always has questionnaire items in proper order order, sort everything in the fetch hooks.
Note: Hub returns the questionnaire in the same order as the original yaml file. We need to make sure things are sorted properly.