Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Selectors to uniquely identify dropdowns #1345

Merged
merged 5 commits into from
Sep 15, 2023
Merged

✨ Selectors to uniquely identify dropdowns #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4ed76f
ApplicationTableAssessment: Top level Toolbar and row actions IDs
gildub Sep 15, 2023
7364007
ApplicationTableAnalysis: Top level Toolbar and row actions IDs
gildub Sep 15, 2023
c7d7436
MigrationWaves: Remove deprecated drowndown and Toolbar and row actio…
gildub Sep 15, 2023
8cc6465
Merge branch 'main' into kebab-ids
ibolton336 Sep 15, 2023
92dfb2d
Merge branch 'main' into kebab-ids
ibolton336 Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/src/app/pages/applications/applications-table-analyze/applications-table-analyze.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ export const ApplicationsTableAnalyze: React.FC = () => {
</RBAC>
</ToolbarItem>
{dropdownItems.length ? (
<ToolbarItem>
<ToolbarItem id="toolbar-kebab">
<Dropdown
isOpen={isToolbarKebabOpen}
onSelect={() => setIsToolbarKebabOpen(false)}
Expand Down Expand Up @@ -631,7 +631,7 @@ export const ApplicationsTableAnalyze: React.FC = () => {
<TagIcon />
{application.tags ? application.tags.length : 0}
</Td>
<Td isActionCell>
<Td isActionCell id="pencil-action">
<Button
variant="plain"
icon={<PencilAltIcon />}
Expand All @@ -640,7 +640,7 @@ export const ApplicationsTableAnalyze: React.FC = () => {
}
/>
</Td>
<Td isActionCell>
<Td isActionCell id="row-actions">
<Dropdown
isOpen={isRowDropdownOpen === application.id}
onSelect={() => setIsRowDropdownOpen(null)}
Expand Down
6 changes: 3 additions & 3 deletions ...rc/app/pages/applications/applications-table-assessment/applications-table-assessment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ export const ApplicationsTable: React.FC = () => {
</RBAC>
</ToolbarItem>
{dropdownItems.length ? (
<ToolbarItem>
<ToolbarItem id="toolbar-kebab">
<Dropdown
isOpen={isToolbarKebabOpen}
onSelect={() => setIsToolbarKebabOpen(false)}
Expand Down Expand Up @@ -649,7 +649,7 @@ export const ApplicationsTable: React.FC = () => {
<TagIcon />
{application.tags ? application.tags.length : 0}
</Td>
<Td isActionCell>
<Td isActionCell id="pencil-action">
<Button
variant="plain"
icon={<PencilAltIcon />}
Expand All @@ -658,7 +658,7 @@ export const ApplicationsTable: React.FC = () => {
}
/>
</Td>
<Td isActionCell>
<Td isActionCell id="row-actions">
<ActionsColumn
items={[
{
Expand Down
Loading