Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE requests 9-7-23 #1336

Closed
ibolton336 opened this issue Sep 7, 2023 · 5 comments
Closed

QE requests 9-7-23 #1336

ibolton336 opened this issue Sep 7, 2023 · 5 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@ibolton336
Copy link
Member

ibolton336 commented Sep 7, 2023

  • Cancel button IDs should all just be 'cancel'. Any more granularity than this causes confusion.
  • Submit button IDs should all just be 'submit'. Any more granularity than this causes confusion.
  • Top table level Kebab ID needs a static ID rather than a PF generated ID for all tables. This one can be table name specific.
  • New actions column kebab needs additional selectors. In some cases we are using two actions columns which aren't differentiated by any ID. Worth looking into dropdown options IDs to make sure they are all different for actions columns.
    https://docs.google.com/spreadsheets/d/1KkSFQBbyXOh9XA3_u9w26KV1urE317EBeaRgddFgLPE/edit#gid=1625701264
@ibolton336 ibolton336 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 7, 2023
@gildub
Copy link
Contributor

gildub commented Sep 8, 2023

@ibolton336,

Did you mean the "Submit button IDs should all just be 'submit'." ?

@ibolton336
Copy link
Member Author

Nailed it! @gildub

@gildub
Copy link
Contributor

gildub commented Sep 8, 2023

@ibolton336, who's point of contact for those QE request ?
Is a "selector" an component id used for uniquely identifying element during tests ?

@ibolton336
Copy link
Member Author

ibolton336 commented Sep 8, 2023

Try @ibragins . I linked the spreadsheet that might give more info also. Thx.

ibolton336 added a commit that referenced this issue Sep 8, 2023
#1336

Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
@gildub
Copy link
Contributor

gildub commented Sep 13, 2023

This is now tracked by #443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

2 participants