Калентьев Илья tg: @m1nus0ne #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2024 23:23
xsitin
reviewed
Dec 27, 2024
TagCloudApp/Results/default.png
Outdated
There was a problem hiding this comment.
Результат генерации получился странным. Крупные слова разбросаны по всему облаку, а так быть не должно
| [Option('d', "destination", HelpText = "Set destination path.", Default = @"..\..\..\Results")] | ||
| public string DestinationPath { get; set; } | ||
|
|
||
| [Option('s', "source", HelpText = "Set source path.", Default = @"..\..\..\Results\text.txt")] |
There was a problem hiding this comment.
Попробуй посмотреть описание любой часто используемой консольной программы, сдеалнное тобой описание не информативно
TagCloud/TagCloudServicesFactory.cs
Outdated
Comment on lines
34
to
41
| if (options.ColorScheme == "gray") | ||
| builder.RegisterType<RandomColorSelector>().As<IColorSelector>().SingleInstance(); | ||
| if (options.ColorScheme == "random") | ||
| builder.RegisterType<GrayScaleColorSelector>().As<IColorSelector>().SingleInstance(); | ||
| else if (ColorConverter.TryConvert(options.ColorScheme, out var color)) | ||
| builder.Register(provider => new ConstantColorSelector(color)).As<IColorSelector>().SingleInstance(); | ||
| else | ||
| builder.Register(provider => new ConstantColorSelector(Color.Black)).As<IColorSelector>().SingleInstance(); |
There was a problem hiding this comment.
эти условия можно заменить полиморфизмом
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.