Ensure ImportThread is always terminated. #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes perfect sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves the problem I observe with v0.3.5: if
-nominatim-importis executed when the database is not reachable, the process never ever exits. This is due toImportThead.finish()never being called, and thusImportThreadnever terminating.Note: this issue is no longer observable with latest code. After 45b3ec7 commit
NominatimConstructorreaches to the database (and fails) beforeImportThreadis created, effectively masking the problem.However it can still fail, should any of the queries in
readEntireDatabase()raise any exception.