Only wait for yellow health status on startup #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation says that the yellow status is reached, when the primary shard is available and green status only when the replica shards are online. Tests are run with a single shard only, thus they can never reach green state because there is no replica shard configured. Waiting for the green status in fact resulted in a silent timeout of the operation after 30s. This made the API tests annoyingly slow. Having the primary shard available should be sufficient for most operations. So this commit changes the status operation to only wait for yellow state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says that the yellow health status is reached, when the primary shard is available and green status only when the replica shards are online. Tests are run with a single shard only, thus they can never reach green state because there is no replica shard configured. Waiting for the green status in fact resulted in a silent timeout of the operation after 30s. This made the API tests annoyingly slow.
Having the primary shard available should be sufficient for most operations. So this commit changes the status operation to only wait for yellow state.
Side note: the status check shouldn't just time out silently but at least omit a warning but that is something for another commit.