Remove request handler factories #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify FilteredPhotonRequest and PhotonRequest and get rid of the factory methods for them. We can also get rid of a couple of generalisations in the search request because of that. Move parsing of filter expressions into PhotonRequest and add proper tests for the parser. Remove the *RequestHandlerTests that only check for setting of internal variables. Remove unused ElasticsearchSearcherFactory.
Merge ReverseRequest classes into a single class and get rid of the factory, which only ever returned the same object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There really is not much point in having flexible Request classes for the different endpoints. In fact, reverse had only one implementation of its abstract Request class and the two instances of PhotonRequest were duplicating each other. This PR slim-lines the code around the Request classes, removes the RequestHandlerFactories and gets rid of a couple of tests which were effectively testing only assignments but causing a lot of trouble for refactoring. I'll readd more meaningful tests in follow-up PRs.