Convert website to simple static html #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The website is simple enough that we don't really need flask or templating to serve it. Therefore remove Python completely from the project and convert the website to a simple staticly servable index.html.
christophlingg
approved these changes
Oct 5, 2020
| @@ -0,0 +1,4 @@ | |||
| API_URL = 'http://localhost:5001/api/?'; | |||
| TILELAYER = 'https://{s}.tile.hosted.thunderforest.com/komoot-2/{z}/{x}/{y}.png'; | |||
There was a problem hiding this comment.
I guess most people have high definition we could use https://{s}.tile.hosted.thunderforest.com/komoot-2/{z}/{x}/{y}@2x.png; instead. But maybe you also know about an option in leaflet to automatically change the URL depending on the display density? I found detectReting but that seems to produce pretty small maps.
There was a problem hiding this comment.
I'll have a look. I wanted to update leaflet anyways. That's a good opportunity to check that as well.
There was a problem hiding this comment.
Use {r} and leaflet will add @2x for those displays which support high resolution https://leafletjs.com/reference-1.7.1.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website is simple enough that we don't really need flask or templating to serve it. Therefore remove Python completely from the project and convert the website to a simple index.html that can be served statically.
@christophlingg, please let me know if I have overseen something that requires the flask setup. This change removes a quiet large moving part for the website setup but also a couple of dependencies that regularly get us security warnings on the github repo.