-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #20 causing regression and add tests for reviver #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like #7 is only removing circular references, but still adding references otherwise: var obj1 = { a: 1 };
var obj = { "prop1": obj1, "prop2": { "prop3": obj1 } };
jsan.stringify(obj, null, null, {circular: '∞'}); It's returning
So we'd need an additional option to disable adding references, but not sure if it will hang for circular structures in that case. |
Merging this and adding |
Thanks for looking into and fixing this |
This was referenced Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #24, it was introduced a regression in #20, so I think it's better to revert it. Additionally to handling references (as per #19), it's disabling stringifying of all special types, also decreases the performance adding another stringifying and because not using
needsRetrocycle
it will also add extra operations during parsing when not needed.I'll look into #19 later, that could be already implemented in #7.