Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

James/remove windows cmd prompt on desktop start #964

Conversation

James-Pickett
Copy link
Contributor

  • reproduced error by replacing binary at bin path
  • tested fix by replacing binary at bin path with build using new flags
  • tested live query against new build

closes #943

RebeccaMahany
RebeccaMahany previously approved these changes Dec 8, 2022
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

seejdev
seejdev previously approved these changes Dec 8, 2022
@James-Pickett James-Pickett dismissed stale reviews from seejdev and RebeccaMahany via 6b08a52 December 8, 2022 16:36
Co-authored-by: CJ Barrett <charlesjbarrett@gmail.com>
@James-Pickett James-Pickett merged commit d49642f into kolide:main Dec 8, 2022
@James-Pickett James-Pickett deleted the james/remove-windows-cmd-prompt-on-desktop-start branch December 8, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On fresh install of windows, with launcher desktop enabled, a cmd prompt stays open
4 participants