Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change file extension to .json for debug log #944

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Change file extension to .json for debug log #944

merged 6 commits into from
Nov 21, 2022

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Nov 18, 2022 •
edited
Loading

Rename debug.log to debug.json. Log rotation is already handled by lumberjack.

Closes #942.

directionless
directionless previously approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but this is not enough to remove the old .log files.

I suspect we should add something to just rm anything that matches the glob RootDir/debug*.log and RootDir/debug*.log.gz. That could land in a separate PR

directionless
directionless previously approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd take it!

@directionless directionless mentioned this pull request Nov 18, 2022
Closed
@RebeccaMahany RebeccaMahany reopened this Nov 21, 2022
@RebeccaMahany RebeccaMahany merged commit c46699b into kolide:main Nov 21, 2022
@RebeccaMahany RebeccaMahany deleted the becca/debug-file-ext branch November 21, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seejdev seejdev seejdev approved these changes

@James-Pickett James-Pickett James-Pickett approved these changes

@directionless directionless directionless left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The debug logs should write to debug.txt
4 participants
@RebeccaMahany @directionless @seejdev @James-Pickett