-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for remotectl + parsing results #915
Add support for remotectl + parsing results #915
Conversation
pkg/osquery/tables/execparsers/remotectl/test-data/single_device_dumpstate.txt
Show resolved
Hide resolved
Here's a redacted 2 device dump from my machine. Weirdly, I see that the apple model names ( Update: and by "2 device" I mean 2 attached devices. So, 3 devices. I have no idea what I was thinking when I named that. |
This is looking good! |
… from remotectl output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested on my own mac including connected to my macbook air.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't stare super hard at the parser, but nothing looked wrong. And it works. LGTM
… than unexported function in test
c7a4779
Closes #763
Adds a parser to parse
remotectl
output.Example output from querying: