Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go to 1.19 #879

Merged
merged 5 commits into from
Sep 8, 2022
Merged

update go to 1.19 #879

merged 5 commits into from
Sep 8, 2022

Conversation

James-Pickett
Copy link
Contributor

@James-Pickett James-Pickett commented Sep 7, 2022 •
edited
Loading

  • ran go mod tidy
  • ran gofmt on all the things
  • set linter to latest version
  • set action linter to latest version
  • tested live query against local instance of k2
  • tested using launcher interactive

@James-Pickett James-Pickett marked this pull request as ready for review September 7, 2022 23:39
directionless
directionless approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt is surprisingly aggressive, but it all seems fine.

Thanks for doing this!

@directionless directionless merged commit 32a9102 into kolide:main Sep 8, 2022
@James-Pickett James-Pickett deleted the james/go-19 branch September 12, 2022 18:09
@James-Pickett James-Pickett mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@James-Pickett @directionless