Rename the initial kolide plugin to kolide_grpc
#851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing with v0.12.0, I'm running into some issues. I'm pretty sure they're because the extension registers as `kolide_initial`, but various things are configured to use `kolide_grpc`. (Which is kinda 🤷 since there are sub extensions with that name. But who knows) Renaming this to kolide_grpc feels like the quickest way. It seems to work in some testing, but I want to get it a bit wider
James-Pickett
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with v0.12.0, I'm running into some issues. I'm pretty sure they're because the extension registers as
kolide_initial, but various things are configured to usekolide_grpc. (Which is kinda 🤷 since there are sub extensions with that name. But who knows)Renaming this to kolide_grpc feels like the quickest way. It seems to work in some testing, but I want to get it a bit wider