James/interactive mode #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tops linux test issues
…he max length works
directionless
previously approved these changes
Jul 20, 2022
Comment on lines
+1
to
+2
| //go:build !windows | ||
| // +build !windows |
There was a problem hiding this comment.
I realized that you're using a socket, which won't work on windows. Windows probably needs a named pipe. This is in pkg/osquery/runtime/runtime_helpers_windows.go
I think it would be fine to ship as is, and then add windows support
…sions server, added error message for running on windows
directionless
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP of working launcher interactive mode
Screen.Recording.2022-06-30.at.8.45.45.AM.mov