Removing osquery-extension

[James-Pickett]

Removes the need for an additional osquery-extension.ext file to run launcher. It may have been required in the past in order to force osquery to wait for other extensions to load. However, now we can add the extensions_require flag when launching osquery and it will cause osquery to respect the extensions_timeout flag before loading the rest of the configuration.

Also adds new flag for autoloading extensions.

[directionless]

So what will actually populate osquery-extension.ext into the options? I had imagined something around

launcher/cmd/launcher/extension.go

Line 215 in fae3d1e

func osqueryRunnerOptions(logger log.Logger, db *bbolt.DB, opts *launcher.Options) ([]runtime.OsqueryInstanceOption, error) {

[directionless]

This is looking pretty nice. Good to remove this stuff.

Could also remove the rosetta install in preinstall-darwin.sh, but probably better in a separate PR.

[directionless]

extensions_require take an argument of which extensions to wait for. Which should probably be set to the union of: autoload, config plugin, logger plugin, distributed plugin

[James-Pickett]

Updated, I should have RTFMed that first. Curious that even passing the option blank caused it to respect the extensions_timeout ... ultimately creating a race condition I suppose. Anyways, I think this is an overall improvement.

[directionless]

I would bet there are bugs lurking

[directionless]

I'm game for testing this as a nightly!

I don't know if we'll need to exempt tls from the required extensions (and other osquery buildins) But we can test on the nightlies.