Fix the duplicate GitHub Actions #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that we were running twice the number of GitHub actions as expected. I believe this is because both the `push` and the `pull_request` triggers were active. This shifts them so the `push` is only on the main branches
blaedj
approved these changes
Apr 20, 2022
| @@ -2,7 +2,7 @@ name: ci | |||
|
|
|||
| on: | |||
| push: | |||
| branches: '**' | |||
There was a problem hiding this comment.
@directionless , this means now CI will only run in my forked repo when I push to a main or master branch ... do we loose anything by having it the way it was?
There was a problem hiding this comment.
It was causing two sets of tests to run on the PRs. One triggered for the push, and one triggered for the PR.
For my branches, I usually push to a draft PR. But maybe there's a way we can get the best of both worlds. I wonder if we can specify fork names or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were running twice the number of GitHub actions as expected. I believe this is because both the
pushand thepull_requesttriggers were active. This shifts them so thepushis only on the main branches