Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get timeout for table generate function from control server #2085

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Get timeout for table generate function from control server #2085

merged 4 commits into from
Feb 3, 2025

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Feb 3, 2025 •
edited
Loading

Updates tablewrapper to pull the generate timeout value from the control server, so that if we need to adjust the timeout on the fly, we can.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review February 3, 2025 17:34
James-Pickett
James-Pickett previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I took a good look at the table wrapper, didn't go over everything else with fine tooth comb. Let me know if there is another part I should focus on.

@RebeccaMahany
Copy link
Contributor Author

@James-Pickett that's the important part, thank you!!

directionless
directionless reviewed Feb 3, 2025
View reviewed changes
@RebeccaMahany RebeccaMahany changed the title Get timeout for generate function from control server Get timeout for table generate function from control server Feb 3, 2025
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Feb 3, 2025
Merged via the queue into kolide:main with commit ddeead5 Feb 3, 2025
32 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/control-generate-timeout branch February 3, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless left review comments

@zackattack01 zackattack01 zackattack01 approved these changes

@James-Pickett James-Pickett James-Pickett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RebeccaMahany @directionless @James-Pickett @zackattack01