Add remote restart consumer to handle remote restart actions #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
commented
Nov 11, 2024
| level.Debug(logger).Log("msg", "run launcher", "stack", fmt.Sprintf("%+v", err)) | ||
| return 1 | ||
| } | ||
| level.Debug(logger).Log("msg", "runLauncher exited to run newer version of launcher", "err", err.Error()) | ||
| level.Debug(logger).Log("msg", "runLauncher exited to reload launcher", "err", err.Error()) | ||
| if err := runNewerLauncherIfAvailable(ctx, slogger.Logger); err != nil { |
There was a problem hiding this comment.
This works on macOS/Linux unless there is nothing to be found in the autoupdate library, in which case launcher will exit and we would have to rely on the init system (launchd/systemd) to restart launcher. (On Windows, we always exit completely and rely on the Service Manager to restart launcher.)
This seems like an okay tradeoff to me, since we will be doing this action only rarely as a troubleshooting step, but I wanted to flag it in case others disagree.
ee/control/consumers/remoterestartconsumer/remoterestartconsumer.go
Outdated
Show resolved
Hide resolved
zackattack01
previously approved these changes
Nov 11, 2024
James-Pickett
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for remote restart actions from the control server.
For this new action, it is important that we perform the action exactly once. This PR contains two features to ensure that the action will only be performed once: