Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize how we log and handle panics #1692

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Standardize how we log and handle panics #1692

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8506853
Log panic in runLauncher call on Windows, since it's in a goroutine
RebeccaMahany Apr 25, 2024
19c97f2
Use preexisting ctx instead of context.TODO for log
RebeccaMahany Apr 25, 2024
46abbe4
Recover from rungroup actor panics
RebeccaMahany Apr 25, 2024
1fbc913
First pass at go wrapper
RebeccaMahany Apr 25, 2024
0c3e673
Merge branch 'main' into becca/win-runLauncher-panic-log
RebeccaMahany Apr 26, 2024
053ef6f
Merge branch 'main' into becca/win-runLauncher-panic-log
RebeccaMahany Apr 29, 2024
90d7f82
Merge remote-tracking branch 'upstream/main' into becca/win-runLaunch…
RebeccaMahany Apr 30, 2024
2bf3abc
Add gowrapper tests
RebeccaMahany Apr 30, 2024
57233f3
Add ctx to gowrapper func
RebeccaMahany Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions cmd/launcher/svc_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,22 @@ func (w *winSvc) Execute(args []string, r <-chan svc.ChangeRequest, changes chan
ctx = ctxlog.NewContext(ctx, w.logger)

go func() {
// Log panics from runLauncher
defer func() {
if r := recover(); r != nil {
w.systemSlogger.Log(context.TODO(), slog.LevelInfo,
"panic occurred in runLauncher",
"err", r,
)
if err, ok := r.(error); ok {
w.systemSlogger.Log(context.TODO(), slog.LevelInfo,
"panic stack trace",
"stack_trace", fmt.Sprintf("%+v", errors.WithStack(err)),
)
}
}
}()

err := runLauncher(ctx, cancel, w.slogger, w.systemSlogger, w.opts)
if err != nil {
w.systemSlogger.Log(ctx, slog.LevelInfo,
Expand Down
Loading