run osq runtime tests on windows #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
commented
Mar 29, 2024
James-Pickett
commented
Mar 29, 2024
James-Pickett
commented
Mar 29, 2024
James-Pickett
changed the title
directionless
previously approved these changes
Apr 2, 2024
Comment on lines
31
to
32
| // This this is only enabled on non-Windows platforms because suspending we have not yet | ||
| // figured out how to suspend a process on windows via golang. |
There was a problem hiding this comment.
(nit) grammar seems wrong. I think I know what you mean, but I'm not totally sure
Comment on lines
+3
to
+4
| // these tests have to be run as admin on windows | ||
|
|
There was a problem hiding this comment.
Is it worth baking this into an if with a either an error or skip?
There was a problem hiding this comment.
I added it to the test main func, it just logs to stdout, the alternative was to added it to ever single test, which seemed tedious
Comment on lines
+122
to
+123
| // This test causes time outs on windows, so it is only run on non-windows platforms. | ||
| // Should investigate why this is the case. |
There was a problem hiding this comment.
I wonder if this timeout is related to our prod issue, or unrelated. I think it's reasonable to refactor (as this PR does) and pick that up next PR
There was a problem hiding this comment.
was thinking the same, merge this then try to dig into this test
directionless
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables osq runtime tests on windows. When running the tests locally on windows, I've only been able to get them to work when running as administrator. I think that's okay?
Thera are a few tests added to
runtime_posix_test.gothat would not run or were flakey on windows.I spent a few hours trying to figure out why the
TestRestarttest would not work consistently on windows, but I was stumped. If anybody has an ideas there, it would be great.