Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a little bit more tracing to enrollment #1564

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add a little bit more tracing to enrollment #1564

merged 2 commits into from
Jan 30, 2024

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jan 30, 2024 •
edited
Loading

We already have some traces for enrollment -- this PR adds a couple more child spans to give us a better sense of timing.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review January 30, 2024 17:14
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jan 30, 2024
Merged via the queue into kolide:main with commit 3874d61 Jan 30, 2024
26 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/enrollment-timing branch January 30, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Pickett James-Pickett James-Pickett approved these changes

@zackattack01 zackattack01 zackattack01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RebeccaMahany @James-Pickett @zackattack01