-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust paths in checkups to accommodate NixOS #1558
Adjust paths in checkups to accommodate NixOS #1558
Conversation
case "darwin": | ||
return "/usr/local/kolide-k2" | ||
case "linux": | ||
if allowedcmd.IsNixOS() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case "darwin": | |
return "/usr/local/kolide-k2" | |
case "linux": | |
if allowedcmd.IsNixOS() { | |
case "darwin", "linux": | |
if allowedcmd.IsNixOS() { |
I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so -- IsNixOS
is an OS check, not if the package manager is in use. I kept it pretty narrowly scoped to start.
I am not sure how much of the changes I've made so far adequately support Nix on Darwin right now -- could be fine, but I haven't tested it at all yet.
A couple checkups refer to the
/usr/local/kolide-k2
directory, which will not exist on NixOS. This PR adjusts paths where necessary to find the appropriate location on NixOS.A successful `launcher doctor` run