Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add circle-dot icon #1547

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Add circle-dot icon #1547

merged 3 commits into from
Jan 12, 2024

Conversation

RebeccaMahany
Copy link
Contributor

Adds support for new icon circle-dot, used to indicate Notify state for end user.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review January 12, 2024 16:22
directionless
directionless approved these changes Jan 12, 2024
View reviewed changes
ee/desktop/user/menu/menu_icon.go
assets.MenubarCircleDotLightmodeShadowPng,
assets.MenubarCircleDotMonochromeIco,
assets.MenubarCircleDotMonochromePng,
)
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make default better while you're here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1548 🙂

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jan 12, 2024
Merged via the queue into kolide:main with commit af3a7aa Jan 12, 2024
25 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/circle-dot branch January 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @directionless