Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version string format for darwin builds #1432

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

zackattack01
Copy link
Contributor

@zackattack01 zackattack01 commented Oct 31, 2023

This cleans up the CFBundleVersion string added to the macOS Info.plist to adhere to the apple standards (i.e. <major>.<minor>.<patch>)
Additional context is in the originating issue here: #1428

@zackattack01 zackattack01 force-pushed the zack/update_plist_bundle_version branch from 98ce005 to f3bc546 Compare October 31, 2023 16:53
@zackattack01 zackattack01 force-pushed the zack/update_plist_bundle_version branch from f3bc546 to f99bb11 Compare October 31, 2023 17:52
@zackattack01 zackattack01 marked this pull request as ready for review October 31, 2023 18:00
@zackattack01 zackattack01 added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 4af0410 Oct 31, 2023
@zackattack01 zackattack01 deleted the zack/update_plist_bundle_version branch October 31, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants