Add access-control-allow-private-network to the preflight
#1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -308,6 +308,10 @@ func (ls *localServer) preflightCorsHandler(next http.Handler) http.Handler { | |||
| w.Header().Set("Access-Control-Allow-Headers", | |||
| "Accept, Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization") | |||
|
|
|||
| // Some modern chrome and derivatives use Access-Control-Allow-Private-Network | |||
| // https://developer.chrome.com/blog/private-network-access-preflight/ | |||
There was a problem hiding this comment.
https://developer.chrome.com/blog/private-network-access-update/ newer docs say this is going to be deprecated -- do we want to add a note about that?
There was a problem hiding this comment.
Suggested change
| // https://developer.chrome.com/blog/private-network-access-preflight/ | |
| // https://developer.chrome.com/blog/private-network-access-preflight/ | |
| // Though it's unclear if this is still needed, see https://developer.chrome.com/blog/private-network-access-update/ |
There was a problem hiding this comment.
Maybe like that?
RebeccaMahany
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.chrome.com/blog/private-network-access-preflight/