[TUF autoupdater] Bump lookup logs up to Info level #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
approved these changes
Sep 14, 2023
| @@ -163,11 +163,11 @@ func runNewerLauncherIfAvailable(ctx context.Context, logger log.Logger) { | |||
| } | |||
|
|
|||
| if newerBinary == "" { | |||
| level.Debug(logger).Log("msg", "nothing newer") | |||
| level.Info(logger).Log("msg", "nothing newer") | |||
There was a problem hiding this comment.
Hrm.
Worth noting that all Info logs land in the system log files. So this is potentially noisy for customers that have centralized windows event logging.
There was a problem hiding this comment.
We can probably revert at least some of these back down to the debug level, now that I've worked through the issue I was trying to troubleshoot 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point in main.go, we haven't set the
Debugflag yet on our logger, so we lose all logs at the debug level. This PR bumps up the log level toInfofor the logs we might care about when debugging autoupdater version selection.