Rungroup improvements: logging #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/rungroup/rungroup.go
Outdated
| // Signal all actors to stop. | ||
| for _, a := range g.actors { | ||
| level.Debug(g.logger).Log("msg", "interrupting actor", "actor", a.name) | ||
| a.interrupt(err.err) |
There was a problem hiding this comment.
Do we want to pass nil here? or leave that for future work?
There was a problem hiding this comment.
I don't feel strongly about it -- I'd been erring on the side of not adjusting any logic for now
Comment on lines
+68
to
+72
| // Wait for all actors to stop. | ||
| for i := 1; i < cap(errors); i++ { | ||
| e := <-errors | ||
| level.Debug(g.logger).Log("msg", "successfully interrupted actor", "actor", e.errorSourceName, "index", i) | ||
| } |
There was a problem hiding this comment.
I know that this is a copy from the original, but this is a weird idiom. Feels like wait groups would be more sensible (if harder to add logging for). Eh, maybe we leave it and adjust later?
James-Pickett
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1205
Builds on oklog/rungroup to add logging, making it possible to identify which actors are not shutting down in a timely manner.