Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds launcher flags to flare #1302

Merged

Conversation

James-Pickett
Copy link
Contributor

@James-Pickett James-Pickett commented Aug 24, 2023

summary.log:

✅	Launcher Flags: launcher flags exists and are parsable

launcherFlags.log:

flags file path: /private/etc/kolide-k2/launcher.flags
flags file is 308 bytes, and was last modified at 2023-07-10 13:31:30.430633404 -0700 PDT

launcher.flags contents:

with_initial_runner
autoupdate
hostname k2device-preprod.kolide.com
root_directory /var/kolide-k2/k2device-preprod.kolide.com
osqueryd_path /usr/local/kolide-k2/bin/osqueryd
enroll_secret_path /etc/kolide-k2/secret
update_channel nightly
transport jsonrpc
autoupdate_interval 1m
autoupdater_initial_delay 1s

@James-Pickett James-Pickett marked this pull request as ready for review August 24, 2023 20:16
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth using our options parser

Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look too hard, but it seems fine. I assume it still works

@James-Pickett James-Pickett merged commit dba7294 into kolide:main Aug 28, 2023
@James-Pickett James-Pickett deleted the james/launcher-config-flare-checkup branch August 28, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants