Remove noisy log + prevent panic after parse #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hipping is disabled on purpose
RebeccaMahany
force-pushed
the
becca/suppress-logship-err
branch
from
dc8f7ac to
beb879a
Compare
directionless
previously approved these changes
Aug 17, 2023
pkg/log/logshipper/logshipper.go
Outdated
Comment on lines
69
to
70
| if shouldEnable { | ||
| parsedUrl, err := url.Parse(ls.knapsack.LogIngestServerURL()) |
There was a problem hiding this comment.
I'm surprised you need this.
https://go.dev/play/p/P2NKDl7t9U_q makes it look like parsing "" will return empty url object. But I guess I'm not sure how to best handle that. So maybe this is good enough
There was a problem hiding this comment.
It will return an empty URL object (and will therefore not panic on parsedUrl.String), but I figured no reason to perform the parse if we don't need to
There was a problem hiding this comment.
Simplified this
directionless
approved these changes
Aug 17, 2023
| parsedUrl, err := url.Parse(ls.knapsack.LogIngestServerURL()) | ||
| if err != nil || parsedUrl.String() == "" { | ||
| if err != nil { |
There was a problem hiding this comment.
thank you for fixing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents filling logs with
error parsing log ingest server url, shipping disabledwhen shipping is disabled on purpose via sending down an empty URL.Also prevents a potential panic trying to access
parsedUrl.String()when parsedUrl can be nil in the event of an actual parse error.