only lock mutex while accessing auth map on runner server #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
changed the title
ee/desktop/runner/server/server.go
Outdated
Comment on lines
136
to
139
| // not using defer here because this function | ||
| // calls the next function rather than returing, | ||
| // this blocks mutex for too long | ||
| ms.mutex.Unlock() |
There was a problem hiding this comment.
I think this is okay -- there's no return earlier here. But at 13 lines between the Lock and the Unlock, I feel nervous about it surviving a refactor. Do you think this makes sense as-is, or can we push this section into a new method with a deferred unlock?
There was a problem hiding this comment.
good call, moved to separate func with defer unlock
directionless
approved these changes
Aug 1, 2023
RebeccaMahany
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.