Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exposes table desktop process info in checkpoint and in kolide_desktop_procs table #1240

Merged
merged 5 commits into from
Jun 30, 2023
Merged

exposes table desktop process info in checkpoint and in kolide_desktop_procs table #1240

merged 5 commits into from
Jun 30, 2023

Conversation

James-Pickett
Copy link
Contributor

@James-Pickett James-Pickett commented Jun 29, 2023 •
edited
Loading

  • bumps timeout on scutil cmd used to determine console users for desktop process from 2 -> 10 seconds
  • exposes table with information about desktop processes
  • adds desktop processes info to checkpointer

@James-Pickett James-Pickett marked this pull request as ready for review June 29, 2023 05:59
RebeccaMahany
RebeccaMahany previously approved these changes Jun 29, 2023
View reviewed changes
directionless
directionless previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ee/desktop/runner/runner.go Outdated
process *os.Process
path string
socketPath string
type ProcessRecord struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to export this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget about that, my brain can't handled an unexported struct and exported properties

@James-Pickett James-Pickett merged commit fa27bbf into kolide:main Jun 30, 2023
@James-Pickett James-Pickett deleted the james/desktop-observability branch June 30, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

@RebeccaMahany RebeccaMahany RebeccaMahany left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@James-Pickett @directionless @RebeccaMahany