Use text/template instead of html/template in packagekit
#1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seejdev
approved these changes
May 8, 2023
These are init script templates, and they were needlessly rendered with `html/template`. This caused false positives, such as https://pkg.go.dev/vuln/GO-2023-1751 while it is probably possible to ignore that, we can also quite reasonable use `text/template` here.
directionless
force-pushed
the
seph/GO-2023-1751
branch
from
4d80d31 to
70f66a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are init script templates, and they were needlessly rendered with
html/template. This caused false positives, such as GO-2023-1751 while it is probably possible to ignore that, we can also quite reasonable usetext/templatehere.