Allowing Windows to find console users without requiring User.UiD #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
previously approved these changes
Apr 13, 2023
James-Pickett
previously approved these changes
Apr 13, 2023
James-Pickett
approved these changes
Apr 13, 2023
|
I'm good with this if @James-Pickett and @seejdev are. I say we merge and get it into beta asap |
1 similar comment
|
I'm good with this if @James-Pickett and @seejdev are. I say we merge and get it into beta asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is an attempt to fix errors like:
We don't actually need the proper UID to do anything critical - it's just used for bookkeeping. So we instead use the username instead of the numeric UID.