Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small autoupdate improvements #1119

Merged
merged 69 commits into from
Apr 27, 2023
Merged

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Apr 6, 2023

Relates to #954.

This is the next step toward using our new TUF infrastructure: a couple small improvements, including addressing code review comments left on #1111 and others:

  • Ensure that repeated errors when trying to autoupdate launcher will not prevent us from trying to update osquery
  • Use a temp directory for staging downloads
  • Add a lock to the library to ensure updates aren't running in multiple places for the same library

Subsequent PRs will tackle the following (order is not set in stone):

  1. Trigger a reload/restart after a successful update; launcher init performs version selection using the new update library (potentially falling back to findNew); launcher performs library tidying after version selection
  2. Other improvements/refactors (use knapsack/flags for configuration, ship a more up-to-date TUF repo)
  3. An "update now" functionality tied to control server
  4. Eventually removing the old notary autoupdater

Previous work:

  1. Run new TUF autoupdater side-by-side with notary autoupdater #1081
  2. Expose data and metrics about new TUF autoupdater #1103
  3. Point to production TUF infra #1108
  4. Perform retry on TUF update #1110
  5. Add library manager to handle TUF downloads #1111

@RebeccaMahany RebeccaMahany marked this pull request as ready for review April 12, 2023 16:23
@RebeccaMahany RebeccaMahany changed the title Run launcher and osqueryd update downloads in parallel Small autoupdate improvements Apr 24, 2023
@RebeccaMahany RebeccaMahany force-pushed the becca/tuf-wg branch 2 times, most recently from 939f13c to 359ebdd Compare April 24, 2023 15:22
Copy link
Contributor

@seejdev seejdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments are helpful, thank you

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not tracking all the details, but it seems okay at a high level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants