Flag day for the new menu format #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seejdev
previously approved these changes
Mar 9, 2023
directionless
force-pushed
the
seph/menu-versioning
branch
from
f6f5a64 to
17a2ca2
Compare
seejdev
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple things as a prep for customer rollout.
First, it adjusts the startup behavior. The desktop no longer always starts for the Kolide tenant. This is to better test customer behavior.
Second, it changes the control flag to enable the desktop. This is to head off a race condition around deployment sequencing. We already have code out, in the wild. So if we ship menu data, it will try to parse it. But we've added functionality that won't display right. So we need some kind of versioning around the menu data. I'm not really sure what that will look like. (specifically, what do we display in the menu, if it can't handle the format). So a flag day feels simplest.
Note: This means all the menus will vanish without corresponding changes in the K2 delivered control data.