Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debugging output from localserver #1058

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

blaedj
Copy link
Contributor

@blaedj blaedj commented Feb 24, 2023

This commit:

  • removes a fmt.Println from the localswrver code (presumably introduced for debugging purposes)

Why?

  • It's breaking my jq-based log parsing :)

directionless
directionless previously approved these changes Feb 24, 2023
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this was my fault.

RebeccaMahany
RebeccaMahany previously approved these changes Feb 24, 2023
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything for jq

This commit:
 - removes a fmt.Println from the localswrver code (presumably
 introduced for debugging purposes)

Why?
 - It's breaking my `jq`-based log parsing :)
@blaedj blaedj dismissed stale reviews from RebeccaMahany and directionless via 0ebc75d February 24, 2023 20:28
@directionless directionless merged commit d3362e6 into kolide:main Feb 24, 2023
@blaedj blaedj deleted the blaedj/rm-println branch February 24, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants