Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons with moar pixels #1036

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Icons with moar pixels #1036

merged 4 commits into from
Feb 15, 2023

Conversation

seejdev
Copy link
Contributor

@seejdev seejdev commented Feb 14, 2023 •
edited
Loading

Two changes:

  • I found that when imagemagick converted the SVGs to .icos, we ended up with white squares particularly for dark mode icons. Changing the generator to convert from PNGs to .icos preserves the transparency
  • Added some new icons, and now all icons are 256x256

@seejdev seejdev marked this pull request as ready for review February 14, 2023 22:22
James-Pickett
James-Pickett previously approved these changes Feb 14, 2023
View reviewed changes
directionless
directionless reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ditch the svgs?

@seejdev seejdev merged commit 7ef7fdf into kolide:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

@James-Pickett James-Pickett James-Pickett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seejdev @directionless @RebeccaMahany @James-Pickett