Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with the latest release of Magicmirror2 #48

Open
wlans opened this issue Jan 1, 2025 · 11 comments
Open

Not working with the latest release of Magicmirror2 #48

wlans opened this issue Jan 1, 2025 · 11 comments

Comments

@wlans
Copy link
Contributor

wlans commented Jan 1, 2025

Upgraded to the latest release of Magicmirror2 and only some events come in.

@langejos
Copy link

langejos commented Jan 1, 2025

Same here. Calendar module works fine, but no events show in the monthly calendar.

@wlans
Copy link
Contributor Author

wlans commented Jan 2, 2025

Could use git bisect to figure out which commit broke it. Will do this when I have time. For now I have checked out the previous tag of magicmirror2. CalendarExt3 is having same issues I saw on reddit.

@philipt99
Copy link

Setting the "maximumEntries: '10000'," in the primary calendar module added the calendar back for me but seemed to break the "Upcoming Events"

@langejos
Copy link

langejos commented Jan 5, 2025

See this MagicMirror forum post for a workaround until the April 1 update will fix it permanently.

@GeeYouEss
Copy link

Setting the "maximumEntries: '10000'," in the primary calendar module added the calendar back for me but seemed to break the "Upcoming Events"

this worked for me! thank you.

@aaronaxvig
Copy link
Contributor

aaronaxvig commented Jan 11, 2025

Setting the "maximumEntries: '10000'," in the primary calendar module added the calendar back for me but seemed to break the "Upcoming Events"

This didn't work for me. Maybe I added it to the wrong location.

                {
                        module: "calendar",
                        header: "US Holidays",
                        position: "top_left",
                        hiddenOnStartup: true,
                        maximumEntries: 10000,
                        config: {
                                calendars: [
                                        {
                                                fetchInterval: 7 * 24 * 60 * 60 * 1000,
                                                symbol: "calendar-check",
                                                url: "https://ics.calendarlabs.com/76/mm3137/US_Holidays.ics"
                                        },

Anyways I did the fix from the forum of switching the git branch and that resolved it. Now I have to remember to switch back in a couple months.

@philipt99
Copy link

philipt99 commented Jan 11, 2025

Setting the "maximumEntries: '10000'," in the primary calendar module added the calendar back for me but seemed to break the "Upcoming Events"

This didn't work for me. Maybe I added it to the wrong location.

                {
                        module: "calendar",
                        header: "US Holidays",
                        position: "top_left",
                        hiddenOnStartup: true,
                        maximumEntries: 10000,
                        config: {
                                calendars: [
                                        {
                                                fetchInterval: 7 * 24 * 60 * 60 * 1000,
                                                symbol: "calendar-check",
                                                url: "https://ics.calendarlabs.com/76/mm3137/US_Holidays.ics"
                                        },

Anyways I did the fix from the forum of switching the git branch and that resolved it. Now I have to remember to switch back in a couple months.

My config looks more like this:

                  {
                        module: "calendar",
                        config: {
                                fade: 'false',
                                tableClass: "large",
                                wrapEvents: 'true',
                                coloredBackground: 'true',
                                maximumEntries: '10000',
                                broadcastPastEvents: 'true',
                                calendars: [
                                        {
                                                fetchInterval: 10 * 60 * 1000,
//                                              symbol: "calendar-day",
                                                url: "https://calendar.google.c>
                                        },

@wlans
Copy link
Contributor Author

wlans commented Jan 11, 2025

Setting the "maximumEntries: '10000'," in the primary calendar module added the calendar back for me but seemed to break the "Upcoming Events"

This didn't work for me. Maybe I added it to the wrong location.

                {
                        module: "calendar",
                        header: "US Holidays",
                        position: "top_left",
                        hiddenOnStartup: true,
                        maximumEntries: 10000,
                        config: {
                                calendars: [
                                        {
                                                fetchInterval: 7 * 24 * 60 * 60 * 1000,
                                                symbol: "calendar-check",
                                                url: "https://ics.calendarlabs.com/76/mm3137/US_Holidays.ics"
                                        },

Anyways I did the fix from the forum of switching the git branch and that resolved it. Now I have to remember to switch back in a couple months.

My config looks more like this:

                  {
                        module: "calendar",
                        config: {
                                fade: 'false',
                                tableClass: "large",
                                wrapEvents: 'true',
                                coloredBackground: 'true',
                                maximumEntries: '10000',
                                broadcastPastEvents: 'true',
                                calendars: [
                                        {
                                                fetchInterval: 10 * 60 * 1000,
//                                              symbol: "calendar-day",
                                                url: "https://calendar.google.c>
                                        },

Does it break upcoming events? I use both.

@aaronaxvig
Copy link
Contributor

OK yeah I moved the setting down into the config inside the module and that fixed it (I am back on master branch now).

@wlans
Copy link
Contributor Author

wlans commented Jan 12, 2025

OK yeah I moved the setting down into the config inside the module and that fixed it (I am back on master branch now).

Can you make a PR to update readme with fix? Gpt can do it really quick

aaronaxvig added a commit to aaronaxvig/MMM-MonthlyCalendar that referenced this issue Jan 17, 2025
kolbyjack added a commit that referenced this issue Jan 22, 2025
Document workaround for issue #48
@sdetweil
Copy link

sdetweil commented Mar 5, 2025

if you use my upgrade script, it will reset to the master branch before update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants