Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move webhooks onto new sharedmain methods #6824

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Move webhooks onto new sharedmain methods #6824

merged 2 commits into from
Feb 21, 2020

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented Feb 12, 2020

Related to knative/pkg#1007, migrates webhook processes onto new WebhookMain methods in the sharedmain package that will retain the existing behavior for now while we decide how to scale webhooks horizontally.

Proposed Changes

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 12, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 12, 2020
@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Feb 12, 2020
@pmorie
Copy link
Member Author

pmorie commented Feb 12, 2020

/retest

@pmorie pmorie force-pushed the separate-webhooks branch 3 times, most recently from 649bfe5 to 6d22387 Compare February 17, 2020 17:13
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2020
@pmorie
Copy link
Member Author

pmorie commented Feb 17, 2020

/retest

3 similar comments
@chizhg
Copy link
Member

chizhg commented Feb 17, 2020

/retest

@pmorie
Copy link
Member Author

pmorie commented Feb 18, 2020

/retest

@pmorie
Copy link
Member Author

pmorie commented Feb 18, 2020

/retest

@pmorie pmorie force-pushed the separate-webhooks branch 5 times, most recently from 3fe9118 to 89fd378 Compare February 20, 2020 16:13
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests 1/3
pull-knative-serving-unit-tests 0/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 21, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 21, 2020
@pmorie
Copy link
Member Author

pmorie commented Feb 21, 2020

/retest

@pmorie
Copy link
Member Author

pmorie commented Feb 21, 2020

/retest

mattmoor
mattmoor reviewed Feb 21, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@knative-prow-robot knative-prow-robot merged commit 0507dcf into knative:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@nak3 nak3 Awaiting requested review from nak3

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmorie @chizhg @knative-test-reporter-robot @knative-prow-robot @mattmoor @googlebot