Add leader election docs #2279
Add leader election docs #2279
Conversation
knative-prow-robot
added
the
size/M
|
|
||
| It is important to be able to provide an HA control plane that is resilient in | ||
| the face of a controller instance unexpectedly dying. Beginning in release 0.13, | ||
| Knative provides the ability to leader elect some controllers. |
There was a problem hiding this comment.
Remove trailing whitespace:
| Knative provides the ability to leader elect some controllers. | |
| Knative provides the ability to leader elect some controllers. |
| At this point, we've configured the controllers to use leader election and we | ||
| can scale the control plane up! | ||
|
|
||
| 1. Now, you can scale the control plane up. |
There was a problem hiding this comment.
Remove trailing whitespace:
| 1. Now, you can scale the control plane up. | |
| 1. Now, you can scale the control plane up. |
| 1. Now, you can scale the control plane up. | ||
|
|
||
| ```bash | ||
| kubectl rollouts restart deployment -n knative-serving controller |
There was a problem hiding this comment.
Remove trailing whitespace:
| kubectl rollouts restart deployment -n knative-serving controller | |
| kubectl rollouts restart deployment -n knative-serving controller |
| ## Next steps | ||
|
|
||
| You can follow the [feature track](https://github.com/knative/pkg/issues/1007) | ||
| to monitor progress as we continue to develop this feature. |
There was a problem hiding this comment.
Add trailing newline:
| to monitor progress as we continue to develop this feature. | |
| to monitor progress as we continue to develop this feature. | |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pmorie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| ## Next steps | ||
|
|
||
| You can follow the [feature track](https://github.com/knative/pkg/issues/1007) |
There was a problem hiding this comment.
This PR seems to be closed now, so I'm not sure why we include this? Is there another link to replace it?
Besides mentioning that the feature is still in development, I'm not sure I'd mention any future plans anyway... (https://developers.google.com/style/future).
| Any of these deployments can be scaled up once leader election is enabled. | ||
|
|
||
| ```shell | ||
| kubectl scale --replicas=2 controller autoscaler-hpa networking-certmanager networking-ns-cert |
There was a problem hiding this comment.
what does this do? Doesn't seem to be explained?
There was a problem hiding this comment.
When I just run this command, I am getting an error:
kubectl scale --replicas=2 controller autoscaler-hpa networking-certmanager networking-ns-cert
error: the server doesn't have a resource type "controller"
Some arg/context seems to missing here, so I am not able to set the replicas to 2 ... ?
There was a problem hiding this comment.
should be kubectl scale --replicas=2 deployments ...
There was a problem hiding this comment.
I suspect this may also need a --namespace argument.
| kubectl scale --replicas=2 controller autoscaler-hpa networking-certmanager networking-ns-cert | ||
| ``` | ||
|
|
||
| Note: include `networking-istio` if Istio is installed. |
There was a problem hiding this comment.
Do we need to include all the ingress options that can be included, e.g. kourier?
There was a problem hiding this comment.
Added some review comments, thanks for adding this @pmorie 😄
| 1. Now, you can scale the control plane up. | ||
|
|
||
| ```bash | ||
| kubectl rollouts restart deployment -n knative-serving controller |
There was a problem hiding this comment.
This just restarts the controller ?
There was a problem hiding this comment.
Should this be removed since it has been done during the previous step?
There was a problem hiding this comment.
+1, it looks like we run this command on both line 57 and on line 46 immediately preceeding.
|
we should also list which eventing components are HA. I tried the eventing |
|
None of the stuff I'm playing with is relevant to this release, so we should proceed with documenting what we have. Once we've sorted out next steps (next milestone) we should include whatever docs updates we need in that planning as well. So please don't block this on that stuff 👍 |
| 1. Now, you can scale the control plane up. | ||
|
|
||
| ```bash | ||
| kubectl rollouts restart deployment -n knative-serving controller |
There was a problem hiding this comment.
+1, it looks like we run this command on both line 57 and on line 46 immediately preceeding.
| Any of these deployments can be scaled up once leader election is enabled. | ||
|
|
||
| ```shell | ||
| kubectl scale --replicas=2 controller autoscaler-hpa networking-certmanager networking-ns-cert |
There was a problem hiding this comment.
I suspect this may also need a --namespace argument.
|
@evankanderson this one can probably be closed. @pmorie wdyt about closing this one? |
|
Closing this since the other PR is merged now. |
Add docs for leader election in serving. Feedback wanted!
Part of knative/pkg#1007