Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some small issues #18

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Fix some small issues #18

merged 2 commits into from
Sep 1, 2021

Conversation

klaasnicolaas
Copy link
Owner

  • Fix error when int value is missing
  • Add an default for the use_json parameter

@klaasnicolaas klaasnicolaas added enhancement Enhancement of the code, not introducing new features. bugfix Fixing a bug. labels Sep 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #18 (18cbbfe) into master (3742080) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files           4        4           
  Lines          93       93           
  Branches       10       10           
=======================================
  Hits           81       81           
  Misses          9        9           
  Partials        3        3           
Impacted Files Coverage Δ
omnikinverter/models.py 100.00% <ø> (ø)
omnikinverter/omnikinverter.py 76.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3742080...18cbbfe. Read the comment docs.

@klaasnicolaas klaasnicolaas merged commit 2d89da0 into master Sep 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2021
@klaasnicolaas klaasnicolaas deleted the fix-errors branch September 17, 2021 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Fixing a bug. enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants